Skip to content

Use stored value of method instead of calling same method again. #15517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

saurabh-parekh
Copy link

@saurabh-parekh saurabh-parekh commented May 25, 2018

Use stored value of method instead of calling same method again.

Description

$block->getPartners() is stored in variable name $partners. So it should use the variable value instead of calling $block->getPartners() again.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. Check the currency drop-down in frontend part.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1688 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @saurabh-aureate. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants