Skip to content

Fixed Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

ankurvr
Copy link
Member

@ankurvr ankurvr commented Jun 1, 2018

Description

On Dashboard Last order's table shows wrong table for specific store view dashboard when you have multiple websites and both have different currencies.

Fixed Issues (if relevant)

  1. Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies

Manual testing scenarios

  1. Create 2 Websites with 1 store in each
  2. Set Default website/store base currency as INR (Indian Rupee)
  3. Set another website/store base currency as USD (US Dollar)
  4. Place Order from both websites with with their default currencies.
  5. Now go to Dashboard and set Store View as All Store Views
  6. See Last Orders table and check order's total amounts and all mounts will be in INR (USD orders will be converted to INR with exchange rate
  7. Now change Store View to USD currency website's store which have orders
  8. See Last Orders table and check order's total amounts. You will find those amounts converted to again into INR to USD. But at this point orders are already in USD so no need to convert amounts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

ankurvr added 2 commits June 1, 2018 16:18
Updated Branch 2.2-develop from Magento 2 upstream
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies magento#15660
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 1, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @ankurvr. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@ankurvr
Copy link
Member Author

ankurvr commented Jun 7, 2018

@magento-engcom-team This solution is already fixed and merged in 2.3 release line.

Thanks for suggesting Porting tool. I will use it next time for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants