Skip to content

[Forwardport] Fix #4803: Incorrect return value from Product Attribute Repository #15723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2018
Merged

[Forwardport] Fix #4803: Incorrect return value from Product Attribute Repository #15723

merged 4 commits into from
Aug 10, 2018

Conversation

julian-van-drielen
Copy link

@julian-van-drielen julian-van-drielen commented Jun 3, 2018 •
edited by sidolov
Loading

Description

Forward pull of PR #15691

@vkublytskyi Suggested this fix to resolve issue 4803,

Fixed Issues (if relevant)

  1. Incorrect return value from Product Attribute Repository #4803: Incorrect return value from Product Attribute Repository

Manual testing scenarios

  1. This can be tested by calling the function Magento\Catalog\Model\Product\Attribute\Repository::getCustomAttributesMetadata and check return type.

Contribution checklist

  • [✓] Pull request has a meaningful description of its purpose
  • [✓] All commits are accompanied by meaningful commit messages
  • [✓] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur changed the title Forward pull for issue 4803 2.1->2.3 [Forwardport] Fix #4803: Incorrect return value from Product Attribute Repository Jul 11, 2018
@orlangur orlangur self-assigned this Jul 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 8, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Aug 10, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 40f046e into magento:2.3-develop Aug 10, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 10, 2018
ENGCOM-2708: [Forwardport] Fix #4803: Incorrect return value from Pro…
f1d027c 
…duct Attribute Repository #15723
@magento-engcom-team
Copy link
Contributor

Hi @cream-julian. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

@sidolov sidolov

Labels
Community Insider: Cream community-insider-contribution Component: Eav Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@julian-van-drielen @magento-engcom-team @orlangur @dverkade @sidolov