Skip to content

[Forwardport] Responsive Design Footers bottom of screen on mobile devices #15118 #15729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Forwardport] Responsive Design Footers bottom of screen on mobile devices #15118 #15729

wants to merge 1 commit into from

Conversation

vijay-wagento
Copy link

Original Pull Request

#15353
Solved footer issue for mobile view

Description

Solved footer issue for mobile view

Fixed Issues (if relevant)

  1. Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices
  2. ...

Manual testing scenarios

  1. Check footer in mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 4, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 4, 2018
@VladimirZaets
Copy link
Contributor

VladimirZaets commented Jun 4, 2018 •
edited
Loading

Hi @vijay-wagento. This fix has some problems. First of all, if page content will be less than 100% of page size that footer will not be on the bottom of the page.
Also if the page will contain some content in the bottom the content will be overlapped by footer and will never be visible.
The right way to fix it presented in this PR

@vijay-wagento
Copy link
Author

@VladimirZaets I created PR from the reference PR you have given using Porting tool.

@VladimirZaets
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, here is your Magento instance.
Admin access: https://pr-15729.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@VladimirZaets
Copy link
Contributor

screen shot 2018-06-04 at 12 20 13

Our automation tool gived you reference to porting tool. In the Magento 2.3 version this fix provide new bug. I attached the screenshot.

@vijay-wagento
Copy link
Author

Hello @VladimirZaets, Thanks we are looking into it.

@VladimirZaets
Copy link
Contributor

@vijay-wagento, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vijay-wagento @magento-cicd2 @VladimirZaets @magento-engcom-team @chirag-wagento