Skip to content

chore: prefer woff and woff2 #15870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Jun 15, 2018
Merged

chore: prefer woff and woff2 #15870

merged 3 commits into from Jun 15, 2018

Conversation

DanielRuf
Copy link
Contributor

Currently all old font formats of the default font(s) are used but are not needed.

IE9+ and others support woff and woff2 which are much smaller and better.

See https://caniuse.com/#feat=woff

@VladimirZaets
Copy link
Contributor

Hi, @DanielRuf , thank you for collaboration, good job!

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Jun 12, 2018

  1. Magento\Framework\View\Asset\MinifierTest::testCSSminLibrary
    Minified CSS differs from initial minified CSS snapshot. Ensure that new CSS is fully valid for all supported browsers and replace old minified snapshot with new one.

How can I create a new snapshot?
It's currently a bit unclear as the Grunt tasks do not seem to automate this.

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants