Skip to content

Don't force enable "Use system value" checkboxes #16000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Don't force enable "Use system value" checkboxes #16000

merged 1 commit into from
Aug 1, 2018

Conversation

likemusic
Copy link
Contributor

Description

"Use system value"

Fixed Issues (if relevant)

No

Manual testing scenarios

  1. Create plugin for \Magento\Config\Block\System\Config\Form\Field with beforeRender() method with code:
$element->setDisabled(true);
$element->setIsDisableInheritance(true);
  1. Open System config page with field disabled by plugin.
    Expected: Field is disabled.
    Current: Field is enabled.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @likemusic. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants