Skip to content

Fix issue #15832 #16012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2018
Merged

Fix issue #15832 #16012

merged 2 commits into from
Jun 14, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jun 11, 2018

Description

Added new less variables for primary button to change font-weight, font-size, font-family without changing default button attributes.

Fixed Issues (if relevant)

  1. No button-primary__font-weight #15832: No button-primary__font-weight

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 12, 2018
This was referenced Jun 12, 2018
Merged
Merged
@sidolov sidolov mentioned this pull request Jun 14, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit dd007e3 into magento:2.2-develop Jun 14, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 14, 2018
ENGCOM-1952: Fix issue #15832 #16012
a43bcf7
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Karlasa Karlasa deleted the fix-15832 branch June 16, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Area: Lib/Frontend Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Karlasa @magento-engcom-team @sidolov