-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] Postpone instantiation of session config by using a proxy #16046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] Postpone instantiation of session config by using a proxy #16046
Conversation
@ishakhsuvarov Could you please check what cause failed travis? Thanks, |
@hitesh-wagento , I'm closing this PR because original was closed due to performance degradation |
@sidolov : the original PR was re-opened and merged, I'm re-opening this PR for re-evaluation if that's ok with you. @hitesh-wagento : it's always better to wait with porting PR's, until the original has been approved :) |
Any update in this PR ? Thanks |
Hi @hitesh-wagento Currently this PR is finishing the process of manual testing. |
Thanks for reply. |
Hi @hitesh-wagento. Thank you for your contribution. |
Original Pull Request
#15929
Description
The session config is initialized too early, on initialisation of the HTTP response object. The init of this config object triggers the load of store-specific configuration, which then caches the resolved config path. This happens before the pathinfo is processed, which defines the current store in multi-storeview environment. By using a proxy the instantiation is postponed.
This problem was introduced in c18e36b.
Fixed Issues (if relevant)
Manual testing scenarios
en
foren_US
andde
forde_DE
)web/url/use_store
set to1
/de
Contribution checklist