Skip to content

[Forwardport] Postpone instantiation of session config by using a proxy #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15929

Description

The session config is initialized too early, on initialisation of the HTTP response object. The init of this config object triggers the load of store-specific configuration, which then caches the resolved config path. This happens before the pathinfo is processed, which defines the current store in multi-storeview environment. By using a proxy the instantiation is postponed.

This problem was introduced in c18e36b.

Fixed Issues (if relevant)

  1. Upgraded to Magento 2.2.4 from Magento 2.1.9 - Locale and Store Configuration issues 'Store View' Locale not being used on frontend, 'Default Config' Locale being used instead  #15205
  2. 2.2.4: Wrong home page loaded in multi store setup  #15245

Manual testing scenarios

  1. Magento 2.2.4
  2. Multiple storeviews, e.g. for different languages (store en for en_US and de for de_DE)
  3. Config web/url/use_store set to 1
  4. Navigate to /de

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 12, 2018
@hitesh-wagento
Copy link
Contributor Author

@ishakhsuvarov Could you please check what cause failed travis?

Thanks,

@sidolov sidolov self-assigned this Jun 18, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 18, 2018

@hitesh-wagento , I'm closing this PR because original was closed due to performance degradation

@sidolov sidolov closed this Jun 18, 2018
@hostep
Copy link
Contributor

hostep commented Jun 24, 2018

@sidolov : the original PR was re-opened and merged, I'm re-opening this PR for re-evaluation if that's ok with you.

@hitesh-wagento : it's always better to wait with porting PR's, until the original has been approved :)

@hostep hostep reopened this Jun 24, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 25, 2018
@hitesh-wagento
Copy link
Contributor Author

@sidolov

Any update in this PR ?

Thanks

@ishakhsuvarov
Copy link
Contributor

Hi @hitesh-wagento
You may observe Pull Request progress and status by looking at the "Projects" section in the right sidebar of the PR.

screen shot 2018-06-27 at 18 46 43

Currently this PR is finishing the process of manual testing.

@hitesh-wagento
Copy link
Contributor Author

Hi @ishakhsuvarov

Thanks for reply.

@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15929 branch September 6, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants