Skip to content

Added and removed unnecessary translation for label/comment tags#16090

Merged
magento-engcom-team merged 5 commits intomagento:2.2-developfrom
yogeshsuhagiya:yogesh-patch-4
Jul 7, 2018
Merged

Added and removed unnecessary translation for label/comment tags#16090
magento-engcom-team merged 5 commits intomagento:2.2-developfrom
yogeshsuhagiya:yogesh-patch-4

Conversation

@yogeshsuhagiya
Copy link
Copy Markdown
Member

Description

Added translation for label and/or comment tags.
Removed unnecessary translation for label and/or comment tags.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented Jun 13, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @yogeshks. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@yogeshsuhagiya
Copy link
Copy Markdown
Member Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @yogeshks. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @yogeshks, here is your Magento instance.
Admin access: https://pr-16090.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@yogeshsuhagiya
Copy link
Copy Markdown
Member Author

yogeshsuhagiya commented Jun 15, 2018

Hello @magento-engcom-team, I've reviewed the test instance but it's not required because almost my changes are in system.xml files of different modules for language translations.

@yogeshsuhagiya
Copy link
Copy Markdown
Member Author

yogeshsuhagiya commented Jun 19, 2018

@magento-engcom-team Hello team, will you please review this PR? And please let me know, is it valid PR or not. 6 days passed but still no response.

@mzeis
Copy link
Copy Markdown
Contributor

mzeis commented Jun 20, 2018

Hi @yogeshks, actually it improves speed of processing when you don't assign somebody yourself. Maintainers do the work in their free time and for example I'm on vacation currently.

Vlad now unassigned us because then you have a chance that somebody else picks up this PR. Please allow some time though for processing for the reasons mentioned above.

Thanks for understanding!

@yogeshsuhagiya
Copy link
Copy Markdown
Member Author

Hi @mzeis , Not an issue, I not aware of it.
Anyway, enjoy your vacation.

@yogeshsuhagiya
Copy link
Copy Markdown
Member Author

@magento-engcom-team Hello team, any update?

@magento-engcom-team magento-engcom-team merged commit 01bf1d3 into magento:2.2-develop Jul 7, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @yogeshks. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants