Skip to content

Backport removed extraneous margin. #16099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

Backport removed extraneous margin. #16099

wants to merge 28 commits into from

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#15936
removed extraneous margin and compensated padding and set both to 0, which creates the same effect

Description

Change in the theme which gives the same effect, but removes the negative margin which was compensated with a padding.

Fixed Issues (if relevant)

  1. extraneous margins on product list and product list items #15308: extraneous margins on product list and product list items

Manual testing scenarios

  1. open list view of products on a page
  2. inspect the list .column.main .product-items and one product .products-list .product-item
  3. check if the negative margin and positive padding are replaced by 0 and if the styling is still correct

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 28 commits June 4, 2018 10:34
[Backport] Product placeholder image resize issue #13636
[Backport] Removed unused class from forms less file.
[Backport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
[Backport] For MSI-377: fix test fixture and mark return processor as @api
[Backport] Fix for issue 911 found on MSI project - Cannot read property source_…
[Backport] Fixes in catalog component blocks [2.3-develop]
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660
[Backport] Fixed Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies
[Backport] Small refactoring to better code readability
[Backport] bugfix checkout page cart icon color
[Backport] fix for dropdown toggle icon in cart
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jun 14, 2018
@orlangur orlangur added this to the Release: 2.1.15 milestone Jun 14, 2018
@orlangur
Copy link
Contributor

Commit history is incorrect. Please check it prior to PR creation.

@orlangur orlangur closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants