Skip to content

[Backport] Fixed set template syntax issue #16112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

[Backport] Fixed set template syntax issue #16112

wants to merge 28 commits into from

Conversation

chirag-wagento
Copy link
Contributor

Original Pull Request

#15825

Description

I have added module name on a template file as per Magento standard coding format.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

I have changed all Magneto Bundle module template. so You can check after login on Magento Dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 28 commits June 4, 2018 10:34
[Backport] Product placeholder image resize issue #13636
[Backport] Removed unused class from forms less file.
[Backport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
[Backport] For MSI-377: fix test fixture and mark return processor as @api
[Backport] Fix for issue 911 found on MSI project - Cannot read property source_…
[Backport] Fixes in catalog component blocks [2.3-develop]
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660
[Backport] Fixed Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies
[Backport] Small refactoring to better code readability
[Backport] bugfix checkout page cart icon color
[Backport] fix for dropdown toggle icon in cart
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@sanganinamrata
Copy link
Member

sanganinamrata commented Jun 14, 2018

@chirag-wagento I'm resolving this PR and create back/forward ports of it. I think that you haven't seen a message in comment #16034 .

@chirag-wagento chirag-wagento deleted the backport-set-template-syntax branch June 14, 2018 07:46
@chirag-wagento
Copy link
Contributor Author

Hello @namratachangani

I can see original PR and Forwardport PR merge before 7 days. #15825, #15912
I can't see any status for backport PR after 7 days.
So I was create manually backport PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants