Skip to content

[Forwardport] Correct typo correction js files #16157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hitesh-wagento
Copy link
Contributor

Correct typo correction js files

Fixed Issues (if relevant)

#15888

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

hitesh-wagento and others added 30 commits June 5, 2018 09:54
[Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme…
[Forwardport] [Changed indentation 2 to 4]
[Forwardport] Add missing table aliases to fields mapping for Customer Group filter…
[Forwardport] [Resolved : limiter float too generic]
[Forwardport] [Resolved : Changing @tab-content__border variable has no effect in B…
[Forwardport] Attribute set save admin controller refactor
[Forwardport] Postpone instantiation of session config by using a proxy
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jun 15, 2018
@VladimirZaets
Copy link
Contributor

Hi @hitesh-wagento, thank you for collaboration. Your branch contains 32 commits over our 2.3-develop branch. Please check that 2.3-develop branch in your Magento fork is the same with branch in magento/magento2/ repository. Unfortunately, we can't accept this PR

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-correct-typo branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants