Skip to content

[Backport 2.2] Captcha: Added unit test for CheckRegisterCheckoutObserver #16160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Jun 15, 2018

Original PR: #16117

Description

This PR adds a missing unit test for \Magento\Captcha\Observer\CheckRegisterCheckoutObserver class.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar changed the title [Backport 2.2] Added unit test for CheckRegisterCheckout [Backport 2.2] Captcha: Added unit test for CheckRegisterCheckoutObserver Jun 15, 2018
@orlangur orlangur self-assigned this Jun 15, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2013 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Captcha Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants