Skip to content

Admin controller product set save refactor #16217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2018

Conversation

AnshuMishra17
Copy link
Contributor

Description
Remove direct use of object manager for admin attribute set save controller using constructor based dependency injection.

Manual testing scenarios
Created a new attribute set in admin under Stores -> Attribute Set -> Add Attribute Set.
Edit an existing attribute set under Stores -> Attribute Set

@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@hitesh-wagento
Copy link
Contributor

hitesh-wagento commented Jun 22, 2018

Hi @ihor-sviziev

Can I create Forwardport and Backport again for this PR ?

@ihor-sviziev
Copy link
Contributor

Hi @hitesh-wagento,
Let's wait when this PR will be merged, also author might want to do it himself

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2093 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9d30672 into magento:2.2-develop Jun 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @AnshuMishra17. Thank you for your contribution.
The changes from your Pull Request should be available with the upcoming 2.2.6 release.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants