-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Submitting search form (mini) with enter key fires event handlers bound by jquery twice #16281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Submitting search form (mini) with enter key fires event handlers bound by jquery twice #16281
Conversation
@vgelani please rewrite branch history so that author of original commit is preserved, also, always add |
@orlangur I have updated PR title.
Thank you. |
@vgelani backport PR must contain author of original PR 153faa6, please cherry-pick this commit and do force push instead of just doing same changes. |
@orlangur I have created manual changes because porting tool is failed to create a PR. In case of this, I have created manual create PR with the same commit message. |
@vgelani it does not matter how you created PR, original PR author must be credited properly. Easiest way is to do cherrypicking. |
@orlangur Yeah, I got it by Magento maintainers what is cherrypicking. But It didn't work now for this PR. I'll take care of new PR. Thank you. |
… handlers bound by jquery twice #16281
Hi @vgelani. Thank you for your contribution. |
Original Pull Request
#15340
Description
When submitting the search form in the header with the enter key on the keyboard, event handlers that were bound to the form submit (through jQuery) are fired twice.
Fixed Issues (if relevant)
Manual testing scenarios
console.log('listening for form submit');
});
Contribution checklist