Moved Config.php out to AbstractConfig to make code DRY and help extn… #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return array | ||
| * @SuppressWarnings(PHPMD.ExcessiveMethodLength) | ||
| */ | ||
| function getCodes(); |
There was a problem hiding this comment.
Please make all public methods explicitly public or better to remove this method from interface
|
Good point, will do. |
okorshenko
pushed a commit
that referenced
this pull request
Oct 27, 2017
Public Pull Requests #11607 [Backport 2.2-develop] Fix AcountManagementTest unit test fail randomly by @adrian-martinez-interactiv4 #11757 Fix #11729 - negative value in excel export [M2.2] by @hauso #11410 "Ignore this notification" isn't working by @crissanclick #11610 FR#6891_22 Add-to-cart checkbox still visible when = false by @mrodespin Fixed Public Issues #11729 Exported Excel with negative number can't be opened by MS Office #11365 "Ignore this notification" isn't working #6891 Add-to-cart checkbox still visible when $canItemsAddToCart = false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows what has been done with Config.php in Ups implementation, which looks most correct to me.
I've not done the DHL carrier, this could be done but involves more changes as one of the config files looks at the carrier file, so have left for now.
All shipping extensions have different switches going on in the system.xml, if we can pull this out it makes it easier for extn developers (less duplicate code). To be clear there is no bug here, this is just a suggested improvement