[Backport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP #16359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y[] = works faster than invoking functions in PHP
magento-engcom-team
added
Component: Checkout
Component: Framework/Webapi
orlangur
approved these changes
Jun 23, 2018
|
Hi @orlangur, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 26, 2018
… ...', $array[] = works faster than invoking functions in PHP #16359
|
Hi @lfluvisotto. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16144
Description
array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP
See note in PHP documentation:
http://php.net/manual/en/function.array-push.php
Note: If you use array_push() to add one element to the array, it's better to use $array[] = because in that way there is no overhead of calling a function.