Skip to content

[Backport]Fixes updating wishlist item if an item object is passed instead its id. #16392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2018
Merged

[Backport]Fixes updating wishlist item if an item object is passed instead its id. #16392

merged 1 commit into from
Jul 4, 2018

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jun 25, 2018 •
edited by sidolov
Loading

Description

Original PR #16372

This PR fixes removing the wishlist item from wishlist while updating it, if instead of id it is sent \Magento\Wishlist\Model\Item object.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Wishlist labels Jun 25, 2018
@eduard13 eduard13 changed the title Fixes updating wishlist item if an item object is passed instead its id. [Backport]Fixes updating wishlist item if an item object is passed instead its id. Jun 25, 2018
@eduard13 eduard13 requested a review from rogyar June 25, 2018 18:38
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 26, 2018
@orlangur orlangur self-assigned this Jun 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2129 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit f2038a9 into magento:2.1-develop Jul 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
ENGCOM-2129: [Backport]Fixes updating wishlist item if an item object…
9ca029c 
… is passed instead its id. #16392
magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2018
ENGCOM-2129: [Backport]Fixes updating wishlist item if an item object…
f266e65 
… is passed instead its id. #16392
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@eduard13 eduard13 deleted the 2.1-develop-update-wishlist-item branch July 18, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@orlangur orlangur

@sidolov sidolov

Labels
Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@eduard13 @magento-engcom-team @orlangur @sidolov