Skip to content

Issue in adding the wishlist of "zero price" product #16494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

gelanivishal
Copy link
Contributor

Description

Fixed add to wishtlist item which price is zero.

Fixed Issues (if relevant)

  1. Issue in adding the wishlist of "zero price" product.  #16479:Issue in adding the wishlist of "zero price" product

Manual testing scenarios

  1. Login as a customer in front end of the website.
  2. Open product with zero price
  3. Click on the wishlist button in the product.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jul 3, 2018

Hi @gelanivishal , we can't reproduce this issue on the vanilla 2.2-develop branch, please, check once again.

Our steps for reproducing:

  1. Create simple product with Price=0.
  2. Login as a customer.
  3. Go to product detail page.
  4. Click ADD TO WISH LIST

Actual result:
Product is added to wishlist without error
16494main

@gelanivishal
Copy link
Contributor Author

@sidolov You can reproduce in v2.2.4 instance, For more information please check #16479

Thank you.

@orlangur
Copy link
Contributor

orlangur commented Jul 3, 2018

@gelanivishal the fix is against 2.2-develop, so, you need to test on 2.2-develop as well, not on other 2.2.x release.

@gelanivishal
Copy link
Contributor Author

@orlangur I have found an issue on v2.2.4 version so Do I push changes on 2.3-develop branch?

Thank you.

@orlangur
Copy link
Contributor

orlangur commented Jul 4, 2018

@gelanivishal no, you should reproduce an issue on 2.2-develop or 2.3-develop and only after this create a PR.

@gelanivishal
Copy link
Contributor Author

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal, here is your Magento instance.
Admin access: https://i-16494-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@gelanivishal
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal, here is your Magento instance.
Admin access: https://i-16494-2-3-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@gelanivishal
Copy link
Contributor Author

@sidolov @orlangur I can reproduce error on 2.3-develop, Please check attached screenshot of above instance
2018-07-04_17-36-29

So, I'll create a new PR for 2.3-develop

Thank you.

@gelanivishal
Copy link
Contributor Author

@sidolov @orlangur I have created a new #16537 PR for 2.3-develop branch

Thank you.

@sidolov
Copy link
Contributor

sidolov commented Jul 4, 2018

@gelanivishal , in this case, I'm closing this PR as not relevant, thank you for the contribution!

@sidolov sidolov closed this Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants