[update] enhance performance on large catalog

[AurelienLavorel]

Description

On Magento update, if you have a big number of order (>100k for my case), you can't pass setup:upgrade step.
Instead of using Magento collection, it's a direct SQL request.

Manual testing scenarios

Upgrade Magento from 2.2.2 to 2.2.5.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @AurelienLavorel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[AurelienLavorel]

@magento-engcom-team ?

[ihor-sviziev]

Related Pull Request:
#15097

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2596 has been created to process this Pull Request

[ihor-sviziev]

Result query will be following:

UPDATE sales_order_address
INNER JOIN sales_order ON sales_order_address.parent_id = sales_order.entity_id
INNER JOIN quote_address ON sales_order.quote_id = quote_address.quote_id
                            AND sales_order_address.address_type = quote_address.address_type
SET sales_order_address.quote_address_id = quote_address.address_id
WHERE sales_order_address.quote_address_id IS NULL

[magento-engcom-team]

Hi @AurelienLavorel. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[rikwillems]

@magento-engcom-team this patch won't work with Enterprise Edition with split database setup.

[ihor-sviziev]

Hi @rikwillems,
Thank you for your feedback! I asked @engcom-backlog-nazar to re-check it.

[ihor-sviziev]

Hi @AurelienLavorel,
We verified issue reported by @rikwillems and actually change from this PR failing in Magento Commerce installation with split database setup.

In such configuration we have 2 split databases

• quotes are located in "checkout" connection. Example:
  

  magento2/app/code/Magento/Quote/Setup/UpgradeSchema.php

  Line 21 in a08f378

  private static $connectionName = 'checkout';

  
  

  magento2/app/code/Magento/Quote/Setup/UpgradeSchema.php

  Lines 130 to 147 in a08f378

  	$connection = $setup->getConnection(self::$connectionName);
  	$connection->modifyColumn(
  	$setup->getTable('quote_address', self::$connectionName),
  	'telephone',
  	['type' => Table::TYPE_TEXT, 'length' => 255]
  	)->modifyColumn(
  	$setup->getTable('quote_address', self::$connectionName),
  	'fax',
  	['type' => Table::TYPE_TEXT, 'length' => 255]
  	)->modifyColumn(
  	$setup->getTable('quote_address', self::$connectionName),
  	'region',
  	['type' => Table::TYPE_TEXT, 'length' => 255]
  	)->modifyColumn(
  	$setup->getTable('quote_address', self::$connectionName),
  	'city',
  	['type' => Table::TYPE_TEXT, 'length' => 255]
  	);

• Orders and addresssed are located in "sales" connection. Example:
  

  magento2/app/code/Magento/Sales/Setup/UpgradeSchema.php

  Line 20 in a08f378

  private static $connectionName = 'sales';

  
  

  magento2/app/code/Magento/Sales/Setup/UpgradeSchema.php

  Lines 154 to 163 in a08f378

  	$connection = $installer->getConnection(self::$connectionName);
  	$connection->modifyColumn(
  	$installer->getTable('sales_order', self::$connectionName),
  	'remote_ip',
  	[
  	'type' => \Magento\Framework\DB\Ddl\Table::TYPE_TEXT,
  	'length' => 45
  	]
  	);
  	}

Could you prepare new PR that fixing this issue OR revert your changes?

[AurelienLavorel]

Yes, I'm mounting an environment with that set up to try.

[ihor-sviziev]

Hi @AurelienLavorel,
Thank you for working on it!

[rikwillems]

@ihor-sviziev Please see my PR as a fix for this issue.