Fix of invalid price for integer currencies when amount less than group size#16590
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Jul 13, 2018
vkublytskyi:int-currency-format-2.2
Merged
Fix of invalid price for integer currencies when amount less than group size#16590magento-engcom-team merged 1 commit intomagento:2.2-developfrom vkublytskyi:int-currency-format-2.2
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
vkublytskyi:int-currency-format-2.2
Conversation
Contributor
|
Hi @vkublytskyi. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
approved these changes
Jul 6, 2018
Contributor
|
@vkublytskyi please pay attention that |
Contributor
|
Hi @orlangur, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jul 13, 2018
…less than group size #16590
Contributor
|
Hi @vkublytskyi. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is backported #16588 and related to #15909.
After correct fixes in #15909 (#15540) client-side formatting starts corrupt prices in currencies without minor units if price amount is less then number group size (usually equal to 3 numbers).
Fixed Issues (if relevant)
Manual testing scenarios
STR:
AC: price 0,001 is displayed (wrongly added 0 to have group separator visible)
ER: price 1 is displayed (no decimal part, no preceding 0)
Contribution checklist