Skip to content

Trim email address in newsletter, forgot password, checkout login and email to a friend form #16640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#16564

Related to issue: #6058

Description

Trim email address by remove leading or trailing space on following forms.

  • Newsletter
  • Checkout login
  • Forgot your password
  • Email to a Friend

Fixed Issues (if relevant)

  1. IE11 user login email validation fails if field has leading or trailing space #6058: IE11 user login email validation fails if field has leading or trailing space

Manual testing scenarios

  1. Open forgot your password page in Firefox or IE browser.
  2. Try to add space before entering an email address in the Email field.
  3. Copy " [email protected] " and paste in the Email field. It will automatically remove leading or trailing space.
  4. Check same on the footer newsletter form
  5. Check same by adding a product to cart and go to checkout page without login. Check an Email Address field under the Shipping Address section.
  6. After login, go to the product view page and go to Email to a Friend form. Check an Email field under Sender and Invitee sections.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants