[Forwardport] Fixed set template syntax in block file#16805
[Forwardport] Fixed set template syntax in block file#16805magento-engcom-team merged 3 commits intomagento:2.3-developfrom
Conversation
|
Hi @gelanivishal. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
| $this->setTemplate($templateFile); | ||
| } else { | ||
| $this->setTemplate('hss/iframe.phtml'); | ||
| $this->setTemplate('Magento_Paypal::hss/iframe.phtml'); |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
| { | ||
| if ($this->_isAfterPaymentSave()) { | ||
| $this->setTemplate('hss/js.phtml'); | ||
| $this->setTemplate('Magento_Paypal::hss/js.phtml'); |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
| } | ||
|
|
||
| $this->setTemplate('form.phtml'); | ||
| $this->setTemplate('Magento_Review::form.phtml'); |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
| if ($reviewsCount == 0) { | ||
| #return __('Be the first to review this product'); | ||
| $this->setTemplate('empty.phtml'); | ||
| $this->setTemplate('Magento_Review::empty.phtml'); |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
| if ($item = $this->findItemById($itemAsArray['item_id'], $items)) { | ||
| $this->itemPriceRenderer->setItem($item); | ||
| $this->itemPriceRenderer->setTemplate('checkout/cart/item/price/sidebar.phtml'); | ||
| $this->itemPriceRenderer->setTemplate('Magento_Tax::checkout/cart/item/price/sidebar.phtml'); |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
| protected function _prepareLayout() | ||
| { | ||
| $this->setTemplate('edit.phtml'); | ||
| $this->setTemplate('Magento_UrlRewrite::edit.phtml'); |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
| /** @var \Magento\User\Model\ResourceModel\User\Collection $users */ | ||
| $users = $this->_userCollectionFactory->create()->load(); | ||
| $this->setTemplate('role/users.phtml')->assign('users', $users->getItems())->assign('roleId', $roleId); | ||
| $this->setTemplate('Magento_User::role/users.phtml') |
There was a problem hiding this comment.
Please, revert fix in places when the template specified dynamically
There was a problem hiding this comment.
Hi,
It looks like you applied not all changes.
Take a look at 46e3c0c - forwardport should contains the same changeset
|
Hello @ihor-sviziev, Please review this commit b405dfa and also check @sidolov's requested comments. Thank you. |
|
@gelanivishal sure, you reverted changes that @sidolov requested, but it's still not full list of changes. |
|
Hello @ihor-sviziev, @sidolov, Other files are already changes in 2.3-develop, Please check your side at once. Thank you. |
gelanivishal
assigned
ishakhsuvarov,
sidolov and
orlangur and unassigned
ihor-sviziev and
ishakhsuvarov
magento-engcom-team
added
Release Line: 2.3
and removed
Component: Review
Component: Tax
Component: UrlRewrite
labels
|
Hi @ihor-sviziev, thank you for the review. |
|
Hi @gelanivishal. Thank you for your contribution. |
7 participants
Original Pull Request
#15339
Description
Fixed set template syntax in block file
Fixed Issues (if relevant)
Manual testing scenarios
N/A
Contribution checklist