[Forwardport] Corrected return message from ProductRuleTest.php#16853
Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom Jul 29, 2018
Merged
Conversation
Contributor
|
Hi @sanganinamrata. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
ihor-sviziev
requested changes
Jul 16, 2018
| 7.5, | ||
| $this->resourceRule->getRulePrice(new \DateTime(), 1, 1, $product->getId()), | ||
| "Catalog price rule doesn't apply to to product with visibility value \"Not Visibility Individually\"" | ||
| "Catalog price rule doesn't ap product with visibility value \"Not Visibility Individually\"" |
Contributor
There was a problem hiding this comment.
It looks like mistake. This file wasn't changed in original PR
ihor-sviziev
approved these changes
Jul 28, 2018
Contributor
|
Hi @ihor-sviziev, thank you for the review. |
Contributor
|
Hi @sanganinamrata. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16721
Description
Corrected return message from ProductRuleTest.php
Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A
Contribution checklist