Skip to content

Removed unused _initDiscount() function #16871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removed unused _initDiscount() function #16871

wants to merge 1 commit into from

Conversation

mageprince
Copy link
Contributor

@mageprince mageprince commented Jul 17, 2018

Description

Remove unused commented function from tax.php

Fixed Issues

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jul 17, 2018
@VladimirZaets
Copy link
Contributor

Hi @mageprince. Thanks for the collaboration. Due to Magento backward-compatible guide we can't remove the protected method usage. Someone can override this method in the self implementation.

@mageprince
Copy link
Contributor Author

@VladimirZaets Yes you are right. We should not remove function due to Backward compatible development. But should remove the unused commented code from files.
There are some issue with this PR in my local so I created a new PR #16875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants