FIXED: FTP user and password strings urldecoded

[javierperezm]

Description

FTP connections can't use user or password strings with special characters, like @ or #.
$user = 'my@mail.com';
$pass = '#my@pass';
$host = 'ftphost.com';
$ftp->connect("ftp://{$user}:{$pass}@{$host}");

connect() calls parse_url() and this will break down bad the special chars...

Solution:
// ...
$user = urlencode($user);
$pass = urlencode($pass);
$ftp->connect( ... );

But connect() method calls ftp_login() without decode the $user and $pass vars

Manual testing scenarios

1. $ftp->connect("ftp://my%23mail.com:mypass@myhost.com"); // this works
2. $ftp->connect("ftp://no_special_chars:mypass@myhost.com"); // this works too

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @javierperezm. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[osrecio]

Hi @javierperezm, Can you check Code Standars error in Travis. The PR looks like OK, but we should solve the problem with Coding Standars before.

[javierperezm]

@osrecio I don't understand the Travis response... the warnings are placed outside my changes, and even outside the class I patched

[osrecio]

@javierperezm Now the Travis is green, without Code Standard issues. I will review ASAP.

[magento-engcom-team]

@javierperezm thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-2425 has been created to process this Pull Request

[aleron75]

Once merged, don't forget you can easily backport this PR to 2.2 with the Porting Tool, read more here.

[magento-engcom-team]

Hi @javierperezm. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.