magento/magento2#14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity.

[swnsma]

• fix default value check in case of type conversion;
• add boolean attribute default value assignment;

Description

Fixed Issues

1. Creating custom customer attribute with default value 0 will cause not saving value for customer entity #14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity

Manual testing scenarios

Steps to

1. Create attribute with type "boolean" and default value via Data Install.

        $eavSetup = $this->eavSetupFactory->create(['setup' => $setup]);
        $eavSetup->addAttribute(
            \Magento\Catalog\Model\Product::ENTITY,
            'custom_product',
            [
                'type' => 'int',
                'label' => 'Custom Product',
                'input' => 'boolean',
                'source' => \Magento\Eav\Model\Entity\Attribute\Source\Boolean::class,
                'global' => \Magento\Eav\Model\Entity\Attribute\ScopedAttributeInterface::SCOPE_GLOBAL,
                'backend' => \Magento\Catalog\Model\Product\Attribute\Backend\Boolean::class,
                'visible' => true,
                'required' => true,
                'user_defined' => false,
                'default' => '0',
                'searchable' => false,
                'filterable' => false,
                'comparable' => false,
                'visible_on_front' => false,
                'used_in_product_listing' => true,
                'unique' => false,
            ]
        );
   
        $entityTypeId = $eavSetup->getEntityTypeId(\Magento\Catalog\Model\Product::ENTITY);
        $attributeSetId = $eavSetup->getDefaultAttributeSetId($entityTypeId);
        $attributeGroupId = $eavSetup->getDefaultAttributeGroupId($entityTypeId, $attributeSetId);
        $this->attributeManagement->assign(
            \Magento\Catalog\Model\Product::ENTITY,
            $attributeSetId,
            $attributeGroupId,
            'custom_product',
            100
        );
   

2. Open Swagger.

3. Create new product with REST API via CATALOGPRODUCTREPOSITORYV1. Attribute 'custom_product' should be missed.
   { "product": { "status": 2, "visibility": 4, "type_id": "simple", "sku": "testattr", "name": "TEST ATTR", "attribute_set_id": 4, "price": 0.5, "weight": 0.0, "extension_attributes": { "stock_item": { "qty": 0, "is_in_stock": true, "use_config_backorders": false, "backorders": 1, "use_config_manage_stock": false } }, "custom_attributes": [ { "attribute_code": "description", "value": "" }, { "attribute_code": "short_description", "value": "" }, { "attribute_code": "weight", "value": "" } ] } }

4. Check a product attribute 'custom_product' value in DB.

Expected result

1. Default attribute value '0' was set for attribute 'custom_product'.

Actual result

1. No value was set for attribute ' custom_product' was set.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @swnsma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sidolov]

Hi @swnsma , please, take a look at failed integration tests

[swnsma]

Hi @sidolov,
Thank you for your review.

I have checked the error, and found next:

1. Problem related to Downloadable products (DP).
2. Attribute of DP - 'links_exists' - has default value '0', which was not applied to products before.
   

   magento2/app/code/Magento/Downloadable/Setup/InstallData.php

   Line 139 in 9f006e0

   'default' => '0',

3. In other place in code expected to receive 'null' default value of the attribute.
   

   magento2/app/code/Magento/Downloadable/Model/Product/Type.php

   Line 171 in 9f006e0

   $hasLinks = $product->getData('links_exist');

My assumption of the solution:

1. Create upgrade script, which will remove default value for the attribute.

[slavvka]

Please remove curly braces {}

[swnsma]

Thank you for the review!

But I have fixed :)

[slavvka]

Thank you! The sniffer checks only changed files so that's okay

[slavvka]

Here you touch the logic that relates to all attributes. Are you sure that all other attributes have null as default value? Won't it break their work?

[swnsma]

Hi @slavvka,

I have two arguments for this point.
First: auto tests have passed successfully.
Second: if you look at the screenshot under, there are list of attributes with default value '0'. After smoke check I have not found strict check '===' with null or 0 values anymore (exception - 'links_exist' attribute).
So, I assume, there should not be any problems for existing set of attributes.
P.S. have checked on Open Source Magento.

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3193 has been created to process this Pull Request

[magento-engcom-team]

Hi @swnsma. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.