Skip to content

[Backport] Issue 5316 #16917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2018
Merged

[Backport] Issue 5316 #16917

merged 2 commits into from
Jul 20, 2018

Conversation

ronak2ram
Copy link
Member

Original Pull Request

#16332

Description

Fix HTML minification problem, when there is a php a comment and no space at the php end tag

Fixed Issues (if relevant)

  1. [2.1.0] HTML minification problem with php tag with a comment and no space at the end #5316: [2.1.0] HTML minification problem with php tag with a comment and no space at the end

Manual testing scenarios

  1. Create a theme and a template file which contains this:
<?php //if ($showDescription):?>
    <div class="product description product-item-description">
        <?php /* @escapeNotVerified */ echo $_helper->productAttribute($_product, $_product->getShortDescription(), 'short_description') ?>
    </div>
<?php //endif; ?>
  1. Enable HTML minification in the backend
  2. Re-deploy static content and view_preprocessed in order to generate minified templates
  3. Check the front page, where template is used.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants