Skip to content

[backport] removed _responsive.less import from gallery.less #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2018
Merged

[backport] removed _responsive.less import from gallery.less #17057

merged 1 commit into from
Jul 24, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jul 23, 2018 •
edited by sidolov
Loading

Backport of PR #16579

Description

As gallery.less is not part of default styles-l and styles-m files and gallery.less is not using any breakpoints there is no need to import _responsive.less

Fixed Issues (if relevant)

none

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev self-assigned this Jul 24, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2491 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7b17bb1 into magento:2.1-develop Jul 24, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 24, 2018
ENGCOM-2491: [backport] removed _responsive.less import from gallery.…
264428b 
…less #17057
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@Karlasa Karlasa deleted the BP-PR-16579 branch August 17, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels
Area: Lib/Frontend Cleanup Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@Karlasa @magento-engcom-team @ihor-sviziev