Skip to content

Customer Account Navigation: Introduce Spaceship Operator + Strict Types #17071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Customer Account Navigation: Introduce Spaceship Operator + Strict Types #17071

merged 1 commit into from
Aug 10, 2018

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jul 24, 2018

Description

Customer Account Block got new way of comparing Sort Order attributes, as well as got Strict Types introduced.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Introduce Strict Types
- Introduce SpaceShip Operator
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@lbajsarowicz lbajsarowicz changed the title Customer Account Navigation changes: Customer Account Navigation: Introduce Spaceship Operator + Strict Types Jul 24, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2597 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 6d51ab0 into magento:2.3-develop Aug 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants