Skip to content

Set proper text-aligh for the <th> element of the Subtotal column in the Creditmemo email #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Set proper text-aligh for the <th> element of the Subtotal column in the Creditmemo email #17153

merged 1 commit into from
Aug 1, 2018

Conversation

TomashKhamlai
Copy link
Contributor

@TomashKhamlai TomashKhamlai commented Jul 25, 2018

Description

Change the markup of the template:art: or edit the styles:lipstick:?
I preferred to keep the semantics of the HTML document and change the styles.

Fixed Issues (if relevant)

  1. We definitely do not need this

Manual testing scenarios

  1. Create an Invoice
  2. Create a Credit Memo
  3. Check the email that was sent to the Customer

Expected result:
screenshot_20180725_025329

Actual result:
screenshot_20180725_025205
The Luma and the Blank theme are affected

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 25, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@TomashKhamlai
Copy link
Contributor Author

@magento-engcom-team give me test instance
I will wonder if these comments work automatically 😮💡

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: https://pr-17153.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants