Skip to content

[Backport] Fixed a grammatical error on the vault tooltip #17200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2018
Merged

[Backport] Fixed a grammatical error on the vault tooltip #17200

merged 2 commits into from
Jul 31, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 27, 2018

Description

Fixed a grammar error in the "What is this" tooltip for Braintree save for later. Changed "you" to "your".

Fixed Issues (if relevant)

  1. Fixed a grammatical error on the vault tooltip #17151: Fixed a grammatical error on the vault tooltip

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17151

@ihor-sviziev ihor-sviziev changed the title Fixed a grammatical error on the vault tooltip [Backport] Fixed a grammatical error on the vault tooltip Jul 28, 2018
@@ -122,7 +122,7 @@
</span>
<div class="field-tooltip-content"
data-target="dropdown"
translate="'We store you payment information securely on Braintree servers via SSL.'"></div>
translate="'We store your payment information securely on Braintree servers via SSL.'"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mage2pratik,
We don't have this change in 2.2-develop and original PR.
Please create revert this part in scope of this PR as we don't have this change in original PR and create new PR into 2.2-develop.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2598 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants