[Forwardport] GoogleAnalytics: Added unit test for order success observer #17204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Basecom
partners-contribution
|
Hi @torhoehn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
ihor-sviziev
requested changes
Jul 28, 2018
| */ | ||
| declare(strict_types=1); | ||
|
|
||
| namespace Magento\GoogleAnalytics\Test\Unit\Block; |
There was a problem hiding this comment.
Namespace should be different. Please cherry-pick following commit:
6be5f32
There was a problem hiding this comment.
@ihor-sviziev Done.
ihor-sviziev
approved these changes
Aug 6, 2018
|
Hi @ihor-sviziev, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 9, 2018
… success observer #17204
|
Hi @torhoehn. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17137
Description
This PR adds missing unit test for
Magento\GoogleAnalytics\Observer\SetGoogleAnalyticsOnOrderSuccessPageViewObserverclassFixed Issues (if relevant)
N/A
Manual testing scenarios
N/A