Skip to content

[Forwardport] Correct return type of methods#17215

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-16988
Jul 29, 2018
Merged

[Forwardport] Correct return type of methods#17215
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-16988

Conversation

@mage2pratik
Copy link
Contributor

Original Pull Request

#16988

Description

Correct return type of methods.

Fixed Issues (if relevant)

  1. Correct return type of methods and typo correction. #15993: Correct return type of methods and typo correction.

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

@mageprince only maintainer's approval leads into creating internal issue for processing PR.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2583 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants