Skip to content

[Forwardport] Added unit test for DB model in backup module#17234

Closed
tiagosampaio wants to merge 1 commit intomagento:2.3-developfrom
tiagosampaio:2.3-develop-PR-port-17063
Closed

[Forwardport] Added unit test for DB model in backup module#17234
tiagosampaio wants to merge 1 commit intomagento:2.3-developfrom
tiagosampaio:2.3-develop-PR-port-17063

Conversation

@tiagosampaio
Copy link
Member

Original Pull Request

#17063

Description

This PR adds a missing unit test for \Magento\Backup\Model\Db model.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2566 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

Hi @tiagosampaio,
Sorry, following PR was created first: #17205
I'm closing this PR as duplicate.

@tiagosampaio tiagosampaio deleted the 2.3-develop-PR-port-17063 branch August 7, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants