Skip to content

[Backport] Add VAT number to email source variables #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2018
Merged

[Backport] Add VAT number to email source variables #17242

merged 1 commit into from
Jul 30, 2018

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#10996

Description

In some countries (the netherlands) it's obligated to display your VAT Number in order/invoice emails/pdfs. This field isn't available in the configVariables and can't be shown using a config path.

Fixed Issues (if relevant)

  1. None that I could find.

Manual testing scenarios

  1. Try to add your VAT Number using {{config path="general/store_information/merchant_vat_number"}}.
  2. Empty value is shown.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev changed the title [Forwardport] Add VAT number to email source variables [Backport] Add VAT number to email source variables Jul 28, 2018
@ihor-sviziev ihor-sviziev self-assigned this Jul 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2577 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

@mageprince mageprince deleted the 2.1-develop-PR-port-10996 branch July 30, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants