Forwardport 2.3 Maintenance: Compare products. Add unit test coverage & missed class property declaration.#17251
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom Aug 2, 2018
swnsma:Forwardport-2.3-Compare-Products
Merged
Forwardport 2.3 Maintenance: Compare products. Add unit test coverage & missed class property declaration.#17251magento-engcom-team merged 2 commits intomagento:2.3-developfrom swnsma:Forwardport-2.3-Compare-Products
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
swnsma:Forwardport-2.3-Compare-Products
Conversation
added 2 commits
July 28, 2018 23:44
- add missed property; - add variable annotation;
- add unit test coverage.
Contributor
|
Hi @swnsma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
miguelbalparda
approved these changes
Jul 31, 2018
Contributor
|
Hi @miguelbalparda, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 2, 2018
…test coverage & missed class property declaration. #17251
Contributor
|
Hi @swnsma. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Contribution checklist