Skip to content

Fixed typo in TaxRuleRepositoryTest class.#17279

Closed
dverkade wants to merge 2 commits intomagento:2.2-developfrom
dverkade:2.2-fix-typo-in-test-name
Closed

Fixed typo in TaxRuleRepositoryTest class.#17279
dverkade wants to merge 2 commits intomagento:2.2-developfrom
dverkade:2.2-fix-typo-in-test-name

Conversation

@dverkade
Copy link
Member

@dverkade dverkade commented Jul 30, 2018

Description

This PR fixes a typo in the TaxRuleRepositoryTest class and changed the method name because the "If" was missing in the name of the method.

Since it's a test we can rename the method without deprecating it.

@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Jul 31, 2018

Hi @dverkade , unfortunately, we can't accept such Pull Requests to 2.2 release line, all code cleanup like typos, spelling mistakes, etc should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide

@sidolov sidolov closed this Jul 31, 2018
@sidolov sidolov self-assigned this Jul 31, 2018
@dverkade
Copy link
Member Author

I have created a PR for Magento 2.3 here: #17293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants