Skip to content

[Backport] Fixed a couple of typos#17338

Closed
mage2pratik wants to merge 1 commit intomagento:2.2-developfrom
mage2pratik:2.2-develop-PR-port-17293
Closed

[Backport] Fixed a couple of typos#17338
mage2pratik wants to merge 1 commit intomagento:2.2-developfrom
mage2pratik:2.2-develop-PR-port-17293

Conversation

@mage2pratik
Copy link
Contributor

Original Pull Request

#17293

Description

  • Changed typo "whith" to "with"
  • Fixed typo and missing word in test name

Fixed Issues

None

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 2, 2018

Hi @mage2pratik , unfortunately, we can't accept such Pull Requests to 2.2 release line, all code cleanup like typos, spelling mistakes, etc should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide

@sidolov sidolov closed this Aug 2, 2018
@mage2pratik mage2pratik deleted the 2.2-develop-PR-port-17293 branch August 10, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants