Skip to content

Prevent iterator from being used by reference #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Prevent iterator from being used by reference #1739

wants to merge 1 commit into from

Conversation

syilmaz
Copy link

@syilmaz syilmaz commented Aug 25, 2015

The following fatal error was being produced when visiting the product page:

Fatal error: An iterator cannot be used with foreach by reference in /var/www/html/magento2/app/code/Magento/Catalog/Block/Product/View/Gallery.php on line 48

Looking at the mentioned line, there is no reason for $image to be a reference. Since it's an object.

@syilmaz syilmaz changed the title Prevent iterator from being used by reference. Fixes fatal error. Prevent iterator from being used by reference Aug 25, 2015
@syilmaz
Copy link
Author

syilmaz commented Aug 25, 2015

The build error doesn't seem to be caused by this PR.

@syilmaz
Copy link
Author

syilmaz commented Sep 8, 2015

Closing off this pull request, as it now has been resolved with commit: c87b0de

@syilmaz syilmaz closed this Sep 8, 2015
@syilmaz syilmaz deleted the fix/iterator-reference branch September 8, 2015 07:43
okorshenko pushed a commit that referenced this pull request Nov 21, 2017
Public Pull Requests

#12302 Fixed 'Non-numeric value' warning on account create/save when DOB field is visible by @vovayatsyuk

Fixed Public Issues

#12146 Customer with empty "Date of Birth" cannot be saved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants