Skip to content

[Forwardport] Fixed issue #13480 - Unable to activate logs after switching from production mode to developer #17477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Aug 9, 2018

Original Pull Request

#15335

Description

Set the ENV value of dev/debug/debug_logging to null when deployment mode is "developer"

Fixed Issues (if relevant)

  1. Unable to activate logs after switching from production mode to developer  #13480: Unable to activate logs after switching from production mode to developer

Manual testing scenarios

  1. Set deployment version to "production"
  2. Clean the cache (if necessary)
  3. Set deployment version to "developer"
  4. Check the "Log To File" field under Stores > Configuration > Advanced > Developer > Debug
  5. "Log To File" field should be enabled

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2729 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @mage2pratik. Thanks for the collaboration.
We tested your fix, but the issue is still reproduced.

Steps:
Run php bin/magento deploy:mode:set production
Clean the cache
Run php bin/magento deploy:mode:set developer
Action result: "Log To File" field is disabled.

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants