Skip to content

[Forwardport] Fix sending duplicate emails #17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2018
Merged

[Forwardport] Fix sending duplicate emails #17714

merged 2 commits into from
Aug 26, 2018

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#17484

Preconditions

  1. Magento 2.2.4 or 2.2.5
  2. Wyomind Cron Scheduler v1.4.0

Description

We installed Wyomind Cron Scheduler v1.4.0 and in the result, we have duplicates email (5-6 emails for 1 order).
This hotfix warns against similar situations with sending duplicate emails and adds a limit of 50 emails per cronjob.

Steps to reproduce:

  1. Disable crontab
  2. Make 2 or more orders
  3. Enable crontab

Expected result

No duplicate Emails.

Actual result

Duplicate Emails.

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants