Skip to content

[Forwardport] ISSUE-17715: Duplicate event in Delete operation transa… #17720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

p-bystritsky
Copy link
Contributor

@p-bystritsky p-bystritsky commented Aug 21, 2018

Original Pull Request

#17718

Description

In \Magento\Framework\EntityManager\Operation\Delete::execute 'entity_manager_delete_before' event was dispatched twice.

Fixed Issues (if relevant)

  1. duplicate event in Delete operation transaction "entity_manager_delete_before" #17715: Duplicate event in Delete operation transaction "entity_manager_delete_before".

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio osrecio assigned osrecio and unassigned osrecio Aug 21, 2018
@miguelbalparda miguelbalparda self-assigned this Aug 21, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2859 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants