Skip to content

Fix translation issue #17735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Fix translation issue #17735

merged 1 commit into from
Aug 28, 2018

Conversation

jignesh-baldha
Copy link
Member

Description

This PR will fix issue in translate file.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Aug 22, 2018

Hi @jignesh-baldha , Can you give me some steps to reproduce the error ? Or we can see this translation?

@jignesh-baldha
Copy link
Member Author

Hello @osrecio please check attached screenshot. Translation for the highlighted area in the screenshot is not working due to spacing in CSV file.

configuration settings stores magento admin

@osrecio osrecio self-requested a review August 22, 2018 12:38
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @jignesh-baldha

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-2863 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 436bbda into magento:2.2-develop Aug 28, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@jignesh-baldha jignesh-baldha deleted the jignesh-patch4 branch August 28, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants