Skip to content

[Forwardport] [Search] Unit test for SynonymAnalyzer model #17837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

[Forwardport] [Search] Unit test for SynonymAnalyzer model #17837

merged 1 commit into from
Sep 11, 2018

Conversation

furseyev
Copy link
Contributor

@furseyev furseyev commented Aug 28, 2018 •
edited by sidolov
Loading

Description

A phpunit test for the \Magento\Search\Model\SynonymAnalyzer class added
Forward port to 2.3 of #17801

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Search labels Aug 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @furseyev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@furseyev furseyev requested a review from rogyar August 28, 2018 11:31
@osrecio osrecio mentioned this pull request Aug 28, 2018
Closed
@osrecio osrecio self-assigned this Aug 28, 2018
@osrecio osrecio self-requested a review August 28, 2018 11:43
osrecio
osrecio approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @furseyev for your ForwardPort. This PR will be process ASAP.

@osrecio osrecio removed the request for review from rogyar August 28, 2018 11:43
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-2893 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit d7bf38c into magento:2.3-develop Sep 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 11, 2018
ENGCOM-2893: [Forwardport] [Search] Unit test for SynonymAnalyzer model
fb415d7 
#17837
@magento-engcom-team
Copy link
Contributor

Hi @furseyev. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osrecio osrecio osrecio approved these changes

Assignees

@osrecio osrecio

Labels
Component: Search Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@furseyev @magento-engcom-team @osrecio @rogyar