Skip to content

API-functional test for Search #17840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Aug 28, 2018

Description

This PR adds API-functional test for /V1/search (searchV1) resource.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

}

/**
* @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need in this case the @magentoApiDataFixture with product_simple ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :) We need it since in case with no products the response from the request is completely different. The idea is to test the search request with some products in the database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's clear now for me 😄

@rogyar
Copy link
Contributor Author

rogyar commented Aug 30, 2018

Hi @osrecio. I've made the requested changes. For some reason, my comment is not displayed here. You can check it in the "Files changed" section

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-2899 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants