-
Notifications
You must be signed in to change notification settings - Fork 9.4k
API-functional test for Search #17840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-functional test for Search #17840
Conversation
Hi @rogyar. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
dev/tests/api-functional/testsuite/Magento/Search/Api/SearchTest.php
Outdated
Show resolved
Hide resolved
} | ||
|
||
/** | ||
* @magentoApiDataFixture Magento/Catalog/_files/product_simple.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need in this case the @magentoApiDataFixture with product_simple
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point :) We need it since in case with no products the response from the request is completely different. The idea is to test the search request with some products in the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's clear now for me 😄
Hi @osrecio. I've made the requested changes. For some reason, my comment is not displayed here. You can check it in the "Files changed" section |
Hi @osrecio, thank you for the review. |
Hi @rogyar. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
This PR adds API-functional test for
/V1/search (searchV1)
resource.Fixed Issues (if relevant)
N/A
Manual testing scenarios
N/A