Skip to content

Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851 #17852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Resolved : Wishlist icon cut on Shopping cart page in mobile view #17851 #17852

wants to merge 6 commits into from

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Aug 29, 2018 •
edited
Loading

Summary

Wishlist icon cut on Shopping cart page in mobile view.

Issue : #17851

Preconditions

  1. Magento 2x - This issue reproduce in all version.

Steps to reproduce

  1. Login in your frontend.
  2. Add any product in Cart.
  3. Go to Shopping cart.
  4. Switch mobile view.

Expected result

  1. Wishlist icon should not cut in mobile view.
    screen shot 2018-08-29 at 17 16 32

Actual result

  1. Wishlist icon cut in mobile view.

wishlist-icon

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Aug 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Aug 29, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, here is your new Magento instance.
Admin access: https://pr-17852.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@osrecio
Copy link
Member

osrecio commented Aug 29, 2018 •
edited
Loading

Hi @hitesh-wagento I can't reproduce this error or solution in Test Instance.

I created a product test: https://pr-17852.engcom.dev.magento.com/test.html I followed the steps and I don't see the "heart" icon in the cart: https://pr-17852.engcom.dev.magento.com/checkout/cart/

screen shot 2018-08-29 at 14 23 54

Can you specify more the details or maybe I missing something?

@osrecio osrecio self-assigned this Aug 29, 2018
@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Aug 29, 2018 •
edited
Loading

Hi @osrecio

Please create account and login thenafter you can see heart (wishlist) icon in cart page.

Thanks

@osrecio
Copy link
Member

osrecio commented Aug 29, 2018

Hi @hitesh-wagento , yes you're right. Sorry.

I can reproduce the issue and your PR is OK.

Can you squash your commits in only 1.

Pull request should have a meaningful description of its purpose

osrecio
osrecio reviewed Aug 29, 2018
View reviewed changes
app/design/adminhtml/Magento/backend/web/css/source/forms/fields/_control-table.less
@@ -122,6 +122,12 @@
}
}

td {
.admin__field-control {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this class should be added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @osrecio

I have changed only one file : a34ab10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your branch with last changes because I'm viewing 2 files modified in this PR : https://github.com/magento/magento2/pull/17852/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Means do you want I will remove that change from my branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your branch 2.2-develop with lasts changes and rebase with your branch and push.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share with me steps. How can I rebase

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this video: https://www.youtube.com/watch?v=mJDCL0uzIpY&list=PLDvMskiz68Q3lLDOe2pMXssh8iVTinRN7&index=1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have commit and push changes can you please check once again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you a ping via EngCom Slack. We can continue by this way.

@osrecio osrecio force-pushed the wishlist-icon-cut branch from 5441b46 to dfbbb7d Compare August 31, 2018 07:25
@osrecio osrecio force-pushed the wishlist-icon-cut branch from dfbbb7d to ee67419 Compare August 31, 2018 07:27
@hitesh-wagento
Copy link
Contributor Author

Created new PR #17877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osrecio osrecio osrecio left review comments

Assignees

@osrecio osrecio

Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hitesh-wagento @magento-engcom-team @osrecio @lionelalvarez