Skip to content

[Backport] Replacing deprecated methods for Magento_Security module. #17871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Backport] Replacing deprecated methods for Magento_Security module. #17871

wants to merge 4 commits into from

Conversation

tiagosampaio
Copy link
Member

Original Pull Request

#17557
Replacing deprecated methods for Magento_Security module.

Description

No description needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Contributor

Hi @tiagosampaio! Can you check the failing tests?

addSuccessMessageptionMessage

seems to be missing a letter.

@tiagosampaio
Copy link
Member Author

@miguelbalparda the fix was applied. My mistake, sorry.

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio
Thank you for your contribution. This pull request has been combined (merged) with #17872 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants