Skip to content

[Forwardport] Fix - Next Page button triggered when filtering Customer grid #17874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2018
Merged

[Forwardport] Fix - Next Page button triggered when filtering Customer grid #17874

merged 3 commits into from
Sep 11, 2018

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Aug 30, 2018

Description

I do change in grid.phtml. There is a missing button type. If we did not put button type then button work as a submit button.

Fixed Issues (if relevant)

  1. Next Page button triggered when filtering Customer grid #17789: Next Page button triggered when filtering Customer grid

Manual testing scenarios

  1. Go to "Sales -> Orders"
  2. "Create new order"
  3. Customer grid is displayed
  4. Focus on any column filter (i.e. text box in email column)
  5. Press ENTER to trigger the filter

Expected result

  1. Filter's AJAX call is triggered
  2. Results don't change because the filter input was empty
  3. Grid is still showing the same page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#17870

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2919 has been created to process this Pull Request

@sidolov sidolov changed the title Fix - Next Page button triggered when filtering Customer grid [Forwardport] Fix - Next Page button triggered when filtering Customer grid Sep 5, 2018
@magento-engcom-team magento-engcom-team merged commit c580a46 into magento:2.3-develop Sep 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants