Start phpunit from vendor bin-dir and use correct PHP env #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary to start php with a hard coded "php" bin. PHPUnit contains a SheeBang in the first line which correclty use the /usr/bin/env command to find the configured PHP bin of the operating system.
|
Just checking, will this work on Windows as well? Windows is second class, but good to support as well whenever possible. |
|
@alankent that's true. I forgot that Windows exists :-) |
|
So it's better to keep explicit php invocation |
|
@antonkril I disagree. It would be better to check the operating system and keep the explicit php invocation for windows but use the environment php for all unix-based systems. Probably needs an update of the PR though. |
|
@cmuench may you please update the PR according to comments? As for me I would keep "php " it is compatible with all platforms. |
okorshenko
pushed a commit
that referenced
this pull request
Dec 11, 2017
[Pangolin] Deliver changes from Sprint 14 - 2.2-develop - MQE-528: Robo commands should override certain files. - MQE-382: Adding custom "assertElementContainsAttribute" method. - MQE-572: Expose selenium configuration from within our .env file - MQE-513: added attachment (screenshots/logs) support in Allure report - MQE-439: .env.example parameter example comment block - MQE-541: changed to use stepKey for test step sequencing. - MQE-569: added SampleTests in module blacklist and not allowed to generate - MQE-570: Sanitize MAGENTO_BASE_URL (.env file) and Selenium params - MQE-574: selector or selectorArray attribute is required for 'click' - MQE-583: set release version to 1.0.0 and updated composer dependencies. - MQE-347: Use a remove tag instead of a remove attribute - MQE-386: MFTF Compatibility with Windows Machine - MQE-592: Audit Test Cases on Firefox/Chrome on Windows/OSX - MQE-599: Move composer.json, README, etc from EE to CE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to start php with a hard coded "php" bin. PHPUnit contains a SheeBang in the first line which correclty use the /usr/bin/env command to find the configured PHP bin of the operating system.